Consider more stdlib decorators to be property-like #12583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
charliermarsh
approved these changes
Jul 30, 2024
|
Nice. |
An error occurred while trying to automatically change base from
alex/is-property
to
main
July 30, 2024 16:42
AlexWaygood
force-pushed
the
alex/is-property-3
branch
from
82cded5
to
d164e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is stacked on top of #12581.
We currently consider
@builtins.propertyand@functools.cached_propertyto be "property-like" decorators, but there are several other similar stdlib decorators that it makes sense to consider when it comes to whether a decorated function has property-like semantics:enum.property,abc.abstractpropertyandtypes.DynamicClassAttribute. This PR updatesruff_python_semantic::analyze::visibility::is_propertyto consider those as well.Test Plan
Added some fixtures.
cargo test.