fix

README.md

@@ -1151,7 +1151,7 @@ For more, see [flake8-pie](https://pypi.org/project/flake8-pie/) on PyPI.
 | PIE790 | no-unnecessary-pass | Unnecessary `pass` statement | 🛠 |
 | PIE794 | dupe-class-field-definitions | Class field `{name}` is defined multiple times | 🛠 |
 | PIE796 | prefer-unique-enums | Enum contains duplicate value: `{value}` |  |
-| PIE800 | no-unnecessary-spread | Unnecessary spread `**` | 🛠 |
+| PIE800 | no-unnecessary-spread | Unnecessary spread `**` |  |
 | PIE807 | prefer-list-builtin | Prefer `list()` over useless lambda | 🛠 |
 
 ### flake8-commas (COM)

resources/test/fixtures/flake8_pie/PIE800.py

@@ -1,4 +1,4 @@
-{**foo,    "bar": True  }
+{**foo,    "bar": True  }  # okay
 {"foo": 1, **{"bar": 1}}  # PIE800
 
 foo({**foo, **{"bar": True}})  # PIE800

src/checkers/ast.rs

@@ -2592,7 +2592,7 @@ where
                     pyflakes::rules::repeated_keys(self, keys, values);
                 }
 
-                if self.settings.enabled.contains(&RuleCode::PIE800) {
+                if self.settings.rules.enabled(&Rule::NoUnnecessarySpread) {
                     flake8_pie::rules::no_unnecessary_spread(self, keys, values);
                 }
             }

src/rules/flake8_pie/mod.rs

@@ -15,7 +15,7 @@ mod tests {
     #[test_case(Rule::NoUnnecessaryPass, Path::new("PIE790.py"); "PIE790")]
     #[test_case(Rule::DupeClassFieldDefinitions, Path::new("PIE794.py"); "PIE794")]
     #[test_case(Rule::PreferUniqueEnums, Path::new("PIE796.py"); "PIE796")]
-    #[test_case(RuleCode::PIE800, Path::new("PIE800.py"); "PIE800")]
+    #[test_case(Rule::NoUnnecessarySpread, Path::new("PIE800.py"); "PIE800")]
     #[test_case(Rule::PreferListBuiltin, Path::new("PIE807.py"); "PIE807")]
     fn rules(rule_code: Rule, path: &Path) -> Result<()> {
         let snapshot = format!("{}_{}", rule_code.code(), path.to_string_lossy());

src/rules/flake8_pie/rules.rs

@@ -1,5 +1,3 @@
-use itertools::EitherOrBoth;
-use itertools::Itertools;
 use log::error;
 use rustc_hash::FxHashSet;
 use rustpython_ast::Located;
@@ -155,33 +153,25 @@ where
     }
 }
 
-
 /// PIE800
-pub fn no_unnecessary_spread(checker: &mut Checker, keys: &[Expr], values: &[Expr]) {
-    for item in keys.iter().zip_longest(values.iter()) {
+pub fn no_unnecessary_spread(checker: &mut Checker, keys: &[Option<Expr>], values: &[Expr]) {
+    for item in keys.iter().zip(values.iter()) {
         match item {
-            EitherOrBoth::Both(_, _) => {}
-            EitherOrBoth::Left(_) => {}
-            EitherOrBoth::Right(value) => {
+            // We only care about when the key is None which indicates a spread `**` inside a dict
+            (None, value) => {
                 if let Located {
                     node: ExprKind::Dict { .. },
                     ..
                 } = value
                 {
-                    let mut diagnostic = Diagnostic::new(
+                    let diagnostic = Diagnostic::new(
                         violations::NoUnnecessarySpread,
                         Range::from_located(value),
                     );
-                    // if checker.patch(&RuleCode::PIE807) {
-                    //     diagnostic.amend(Fix::replacement(
-                    //         "pooooooooooooooooo".to_string(),
-                    //         value.location,
-                    //         value.end_location.unwrap(),
-                    //     ));
-                    // }
                     checker.diagnostics.push(diagnostic);
                 }
             }
+            (_, _) => {}
         }
     }
 }

src/rules/flake8_pie/snapshots/ruff__rules__flake8_pie__tests__PIE800_PIE800.py.snap

@@ -2,16 +2,6 @@
 source: src/rules/flake8_pie/mod.rs
 expression: diagnostics
 ---
-- kind:
-    NoUnnecessarySpread: ~
-  location:
-    row: 1
-    column: 11
-  end_location:
-    row: 1
-    column: 16
-  fix: ~
-  parent: ~
 - kind:
     NoUnnecessarySpread: ~
   location:
@@ -52,24 +42,4 @@ expression: diagnostics
     column: 27
   fix: ~
   parent: ~
-- kind:
-    NoUnnecessarySpread: ~
-  location:
-    row: 12
-    column: 11
-  end_location:
-    row: 12
-    column: 16
-  fix: ~
-  parent: ~
-- kind:
-    NoUnnecessarySpread: ~
-  location:
-    row: 16
-    column: 15
-  end_location:
-    row: 16
-    column: 20
-  fix: ~
-  parent: ~
 

src/violations.rs

@@ -4987,18 +4987,11 @@ impl Violation for PreferUniqueEnums {
 define_violation!(
     pub struct NoUnnecessarySpread;
 );
-impl AlwaysAutofixableViolation for NoUnnecessarySpread {
+impl Violation for NoUnnecessarySpread {
+    #[derive_message_formats]
     fn message(&self) -> String {
         format!("Unnecessary spread `**`")
     }
-
-    fn autofix_title(&self) -> String {
-        format!("Remove unnecessary spread `**`")
-    }
-
-    fn placeholder() -> Self {
-        NoUnnecessarySpread
-    }
 }
 
 define_violation!(