-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plugin scaffold for tryceratops with TRY300 #2055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrugman
force-pushed
the
feat-tryceratops
branch
from
January 21, 2023 12:55
4b1169c
to
996d630
Compare
Cool, this looks good. Just for planning and coordination, do you plan on implementing more of the rules from this plugin? |
Yes, I'm working on TC004: Prefer TypeError exception for invalid type - can do in separate PR so that others can see/pick others if they like |
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jan 21, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.228` -> `^0.0.229` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.229/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.229/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.229/compatibility-slim/0.0.228)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.229/confidence-slim/0.0.228)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.229`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.229) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.228...v0.0.229) ##### What's Changed - README: `--force-exclude` is already set by [@​hugovk](https://togithub.com/hugovk) in [https://github.com/charliermarsh/ruff/pull/2042](https://togithub.com/charliermarsh/ruff/pull/2042) - Upgrade to toml v0.5.11 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2040](https://togithub.com/charliermarsh/ruff/pull/2040) - Add support for pycodestyle E101 by [@​ericroberts](https://togithub.com/ericroberts) in [https://github.com/charliermarsh/ruff/pull/2038](https://togithub.com/charliermarsh/ruff/pull/2038) - \[`flake8-executable`] EXE003-005 by [@​sbrugman](https://togithub.com/sbrugman) in [https://github.com/charliermarsh/ruff/pull/2023](https://togithub.com/charliermarsh/ruff/pull/2023) - perf: Reduce allocations by [@​Stranger6667](https://togithub.com/Stranger6667) in [https://github.com/charliermarsh/ruff/pull/2045](https://togithub.com/charliermarsh/ruff/pull/2045) - refactor: RuleOrigin, RuleCodePrefix and Rule::origin by [@​not-my-profile](https://togithub.com/not-my-profile) in [https://github.com/charliermarsh/ruff/pull/2029](https://togithub.com/charliermarsh/ruff/pull/2029) - Add scaffolding for `flake8-type-checking` extension by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2048](https://togithub.com/charliermarsh/ruff/pull/2048) - De-duplicate SIM102 by [@​harupy](https://togithub.com/harupy) in [https://github.com/charliermarsh/ruff/pull/2050](https://togithub.com/charliermarsh/ruff/pull/2050) - Fix S101 range to only highlight `assert` by [@​harupy](https://togithub.com/harupy) in [https://github.com/charliermarsh/ruff/pull/2052](https://togithub.com/charliermarsh/ruff/pull/2052) - Avoid removing comments in RUF005 by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2057](https://togithub.com/charliermarsh/ruff/pull/2057) - Revert "Upgrade to toml v0.5.11" by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2058](https://togithub.com/charliermarsh/ruff/pull/2058) - Pyupgrade: Printf string formatting by [@​colin99d](https://togithub.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/1803](https://togithub.com/charliermarsh/ruff/pull/1803) - \[`flake8-builtins`] Add `builtins-ignorelist` Option by [@​saadmk11](https://togithub.com/saadmk11) in [https://github.com/charliermarsh/ruff/pull/2061](https://togithub.com/charliermarsh/ruff/pull/2061) - feat: plugin scaffold for tryceratops with TRY300 by [@​sbrugman](https://togithub.com/sbrugman) in [https://github.com/charliermarsh/ruff/pull/2055](https://togithub.com/charliermarsh/ruff/pull/2055) - Avoid flagging redefined imports as unused in same-scope by [@​charliermarsh](https://togithub.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/2065](https://togithub.com/charliermarsh/ruff/pull/2065) ##### New Contributors - [@​hugovk](https://togithub.com/hugovk) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2042](https://togithub.com/charliermarsh/ruff/pull/2042) - [@​ericroberts](https://togithub.com/ericroberts) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2038](https://togithub.com/charliermarsh/ruff/pull/2038) - [@​sbrugman](https://togithub.com/sbrugman) made their first contribution in [https://github.com/charliermarsh/ruff/pull/2023](https://togithub.com/charliermarsh/ruff/pull/2023) **Full Changelog**: astral-sh/ruff@v0.0.228...v0.0.229 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDguMSIsInVwZGF0ZWRJblZlciI6IjM0LjEwOC4xIn0=--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed to TRY to avoid conflicts, as proposed in guilatrova/tryceratops#55
https://github.com/guilatrova/tryceratops/blob/main/docs/violations/TC300.md
See: #2056