-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement bandit's 'hardcoded-sql-expressions' S608 #2698
Merged
+736
−0
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fa1e667
Implement bandit's 'hardcoded-sql-expressions' S608
mattoberle 0784d16
Merge branch 'main' into flake8-bandit/S608
charliermarsh 98b4d8f
cargo dev generate-all
charliermarsh b7b161e
Merge branch 'main' into flake8-bandit/S608
charliermarsh 57193ef
Add docs
charliermarsh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Add docs
- Loading branch information
commit 57193ef17c08a14af9f949e22f52f2ba9ebc69ed
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# hardcoded-sql-expression (S608) | ||
|
||
Derived from the **flake8-bandit** linter. | ||
|
||
### What it does | ||
Checks for strings that resemble SQL statements involved in some form | ||
string building operation. | ||
|
||
### Why is this bad? | ||
SQL injection is a common attack vector for web applications. Unless care | ||
is taken to sanitize and control the input data when building such | ||
SQL statement strings, an injection attack becomes possible. | ||
|
||
### Example | ||
```python | ||
query = "DELETE FROM foo WHERE id = '%s'" % identifier | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section implies that sanitizing inputs is alright ... when actually directly interpolating user input into SQL queries should always be avoided (no matter if sanitized or not).
You should instead use "parameter binding" ... also called "server-side binding", where the parameters are sent separately from the query to the server, see e.g. psycopg2 server-side binding.
So I think it would make sense to update this section accordingly.