Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if req name and metadata name mismatch #2484

Closed
wimglenn opened this issue Mar 16, 2024 · 2 comments · Fixed by #2516
Closed

Fail if req name and metadata name mismatch #2484

wimglenn opened this issue Mar 16, 2024 · 2 comments · Fixed by #2516
Assignees
Labels
bug Something isn't working

Comments

@wimglenn
Copy link
Contributor

pip refuses to install a .whl if the req is wrong, e.g.

$ pip install 'dateutil @ file:///tmp/python_dateutil-2.9.0.post0-py2.py3-none-any.whl'
Processing /tmp/python_dateutil-2.9.0.post0-py2.py3-none-any.whl
ERROR: dateutil has an invalid wheel, .dist-info directory 'python_dateutil-2.9.0.post0.dist-info' does not start with 'dateutil'

uv pip install should probably do the same? currently, it's happy with something like

uv pip install 'whatever @ file:///tmp/python_dateutil-2.9.0.post0-py2.py3-none-any.whl'
@zanieb
Copy link
Member

zanieb commented Mar 16, 2024

Thanks for the report. I imagine this would be annoying before we do #313, otherwise I'm all for it.

@zanieb zanieb added the bug Something isn't working label Mar 16, 2024
@charliermarsh
Copy link
Member

We enforce this in most cases — definitely when building source distributions. We probably need to add enforcement in a few codepaths. (I don’t think #313 is required.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants