-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bootstrap install script on windows #1162
Conversation
Windows doesn't support symlinks, doesn't use a `bin` directory and all pythons are called `python.exe`. Note that this is still broken, `.\bin\python3.10.13` is missing its .exe extension and renaming it to `.\bin\python3.10.13.exe` makes it complain about not finding python310.dll.
I could link the dll to the same directory, but that doesn't work with different patch versions since the dlls have only major and minor version. |
How are we supposed to register new Python versions? |
You have to register them in the windows registry (PEP 514) |
An alternative would be a nested PATH:
|
How does discovery work with the nested path? |
We would have to implement this ourselves, i don't know a way that works with I think the lack of a PATH that can be used with different versions is the main reason why |
I mean I guess I'm fine with having the |
@zanieb Can we still merge this? Currently the script doesn't run at all (no symlinking) and this also adds pipx support |
# /// script | ||
# requires-python = ">=3.11" | ||
# dependencies = [ | ||
# "zstandard==0.22.0", | ||
# ] | ||
# /// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this comment?
Does pipx support this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems I used old pipx. Now I can ran it.
I understand this is PEP 723.
Windows doesn't support symlinks, doesn't use a
bin
directory and all pythons are calledpython.exe
.Note that this is still broken,
.\bin\python3.10.13
is missing its .exe extension and renaming it to.\bin\python3.10.13.exe
makes it complain about not finding python310.dll.