Support recursive extras #1435
Merged
Support recursive extras #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Feb 16, 2024
| extra: Option<&ExtraName>, | ||
| source: Option<&PackageName>, | ||
| source_name: Option<&PackageName>, | ||
| source_extra: Option<&ExtraName>, |
There was a problem hiding this comment.
I just renamed and re-ordered these (especially since extra got shadowed below).
zanieb
approved these changes
Feb 16, 2024
|
Are these warnings only visible with |
|
Yeah |
jankatins
reviewed
Feb 16, 2024
| @@ -735,6 +735,76 @@ fn multiple_extras_required() { | |||
| assert_installed(&context.venv, "c_502cbb59", "1.0.0", &context.temp_dir); | |||
| } | |||
|
|
|||
| /// all-extras-required | |||
| /// | |||
| /// Multiple optional dependencies are requested for the via an 'all' extra. | |||
There was a problem hiding this comment.
Suggested change
| /// Multiple optional dependencies are requested for the via an 'all' extra. | |
| /// Multiple optional dependencies are requested for the package via an 'all' extra. |
There was a problem hiding this comment.
Thanks! This file is actually generated. If you want to fix it, it's sourced from https://github.com/zanieb/packse/blob/main/scenarios/extras.json
zanieb
added a commit
to astral-sh/packse
that referenced
this pull request
Feb 16, 2024
From astral-sh/uv#1435 --------- Co-authored-by: Zanie <contact@zanie.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had a guard in the resolve to avoid "self-dependencies" (as in
gps3==0.33.3), but this guard was unintentionally filtering out recursive extras.Closes #1342.
Test Plan
Taken from #1352.