uv-client: fix linehaul test #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was introduced in 42973cd. It looks like it compares some values against some platform specific code that attempts to find the OS version. But the comparisons made some assumptions about what kind of data is available. In this commit, we try to make the test a little more flexible on Linux by not assuming that `Option` values are `Some`.
BurntSushi
requested review from
charliermarsh,
zanieb and
konstin
and removed request for
zanieb
|
cc @samypr100 |
konstin
approved these changes
Mar 25, 2024
|
Thanks, changes look good. Sorry for the unnecessary panics that could've occured on some cases outside of ubuntu. |
|
Related #2564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was introduced in 42973cd. It
looks like it compares some values against some platform specific code
that attempts to find the OS version. But the comparisons made some
assumptions about what kind of data is available. In this commit, we try
to make the test a little more flexible on Linux by not assuming that
Optionvalues areSome.