Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename uv-traits and split into separate modules #2674

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Mar 26, 2024

This is driving me a little crazy and is becoming a larger problem in #2596 where I need to move more types (like Upgrade and Reinstall) into this crate. Anything that's shared across our core resolver, install, and build crates needs to be defined in this crate to avoid cyclic dependencies. We've outgrown it being a single file with some shared traits.

There are no behavioral changes here.

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Mar 26, 2024
@zanieb zanieb marked this pull request as ready for review March 26, 2024 19:54
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@zanieb
Copy link
Member Author

zanieb commented Mar 26, 2024

Sorry about the diff 🤷‍♀️

@zanieb zanieb merged commit 0b08ba1 into main Mar 26, 2024
31 checks passed
@zanieb zanieb deleted the zb/traits-types branch March 26, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants