Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port all git functionality to use git CLI #3833

Merged
merged 6 commits into from
May 30, 2024
Merged

Port all git functionality to use git CLI #3833

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e250c4
port all git functionality to use git CLI
ibraheemdev May 23, 2024
3b8f4f7
fix git clone paths on windows
ibraheemdev May 28, 2024
85afe47
update git todos
ibraheemdev May 30, 2024
674cec7
update git comments
ibraheemdev May 30, 2024
d0c9143
use `simplified_display` instead of `portable_display`
ibraheemdev May 30, 2024
915d8d8
use `exec_with_output` instead of `exec_with_streaming`
ibraheemdev May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update git todos
  • Loading branch information
@ibraheemdev
ibraheemdev committed May 30, 2024
commit 85afe471d6971414a5dcf6b46706af5b3e470751
8 changes: 1 addition & 7 deletions crates/uv-git/src/git.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ impl GitRepository {

/// Initializes a Git repository at `path`.
fn init(path: &Path) -> Result<GitRepository> {
// TODO: see if this still necessary
// TODO(ibraheem): see if this still necessary now that we no longer use libgit2
// Skip anything related to templates, they just call all sorts of issues as
// we really don't want to use them yet they insist on being used. See #6240
// for an example issue that comes up.
Expand Down Expand Up @@ -403,12 +403,6 @@ impl GitCheckout {
let _ = paths::remove_file(&ok_file);
debug!("reset {} to {}", self.repo.path.display(), self.revision);

// TODO: see if this still necessary
// Ensure libgit2 won't mess with newlines when we vendor.
// if let Ok(mut git_config) = self.repo.config() {
// git_config.set_bool("core.autocrlf", false)?;
// }

// Perform the hard reset.
ProcessBuilder::new("git")
.arg("reset")
Expand Down