Allow injecting certificate for tests #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built on #609 When activating the `puffin-test-custom-ca-cert` feature, you can inject a custom ssl certificate by setting `PUFFIN_TEST_CA_CERT_PEM` to a pem file, e.g. ```bash PUFFIN_TEST_CA_CERT_PEM=$(pwd)/mitmproxy-ca-cert.pem ./offlinepi record cargo test --features pypi --features puffin-test-custom-ca-cert -- --test-threads=1 ``` This feature is off by default, so this is not possible in release builds.
Raises "SIGSEGV: invalid memory reference" 😵💫 |
|
Some commentary at #609 (comment) I like this, but also think we need a user-facing way to use system certs. |
|
I think those are two separate issues; I also wouldn't recommend people to change their system trust store to run puffin unit tests. |
|
I think this PR is fine, but the segfault is a problem in general |
|
Yeah the segfault seems non-deterministic and more likely to occur with parallelism |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #609
When activating the
puffin-test-custom-ca-certfeature, you can inject a custom ssl certificate by settingPUFFIN_TEST_CA_CERT_PEMto a pem file, e.g.This feature is off by default, so this is not possible in release builds.