add formatter flake output (nixpkgs-fmt)
#220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astro
requested changes
Mar 20, 2024
Comment on lines
+91
to
+92
| } | ||
| { |
There was a problem hiding this comment.
These curly braces being on different indentation levels illustrates well why I don't like any of the current formatters.
| inherit self nixpkgs system hypervisor; | ||
| }; | ||
| in | ||
| builtins.foldl' |
|
Tbh, I fully agree, the curly braces look awful 😖 In the end I just wanted to make collaboration easier by having enforced standards, even if they're shitty. But I'm not going to waste our time any further with this and will just disable my autoformatting in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the suggestion from here #35 and uses
nixpkgs-fmt. I opted for it since it looked the least weird. IMOalejandrahas not enough spacing andnixfmtuses a bit too much.Anyways, feel free to suggest using another formatter. I just want to have a consistent formatting here which I can apply right before committing so that my own auto-formatting isn't getting in the way 😅
I separated adding the formatter and formatting the code here into two commits so we could optionally omit the latter and do the actual formatting later to prevent merge conflicts.