Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Firestore to Snowflake DAG Defaulting to 0 Score when No Feedback #291

Closed
davidgxue opened this issue Feb 2, 2024 · 0 comments · Fixed by #304
Closed

Load Firestore to Snowflake DAG Defaulting to 0 Score when No Feedback #291

davidgxue opened this issue Feb 2, 2024 · 0 comments · Fixed by #304
Assignees
@davidgxue
Labels
bug Something isn't working
Milestone
0.3.0

Comments

@davidgxue
Copy link
Contributor

Describe the bug

Version

  • OS:

To Reproduce
Steps to reproduce the behavior:

Expected behavior

Screenshots

Additional context
@davidgxue davidgxue added the bug Something isn't working label Feb 2, 2024
@davidgxue davidgxue added this to the 0.3.0 milestone Feb 16, 2024
@davidgxue davidgxue self-assigned this Feb 20, 2024
@davidgxue davidgxue mentioned this issue Feb 23, 2024
Merged
@davidgxue davidgxue changed the title Load Firestore to Snowflake DAG Defaulting to 0 Score when No Feedback [Blocked] Load Firestore to Snowflake DAG Defaulting to 0 Score when No Feedback Feb 23, 2024
@davidgxue davidgxue changed the title [Blocked] Load Firestore to Snowflake DAG Defaulting to 0 Score when No Feedback Load Firestore to Snowflake DAG Defaulting to 0 Score when No Feedback Mar 1, 2024
davidgxue added a commit that referenced this issue Mar 1, 2024
@davidgxue @Lee-W
Fix No Feedback Defaults to 0 Score (Negative Feedback) in Snowflake (#…
4ba6d00 
…304)

### Description
- Super simple code change
- Also changing snowflake db table schema (not code change not shown in
PR)
- Tested by creating new firestore collection indexes

closes #291
closes #296 (second issue is used to test, no code change related)
closes #275

---------

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidgxue davidgxue

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Fix No Feedback Defaults to 0 Score (Negative Feedback) in Snowflake astronomer/ask-astro
1 participant
@davidgxue