-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Backend Message and Frontend Banner for Service Maintenance #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
sunank200
force-pushed
the
banner-alert
branch
from
February 12, 2024 17:47
cda150d
to
2398b1e
Compare
sunank200
force-pushed
the
banner-alert
branch
from
February 12, 2024 18:02
2398b1e
to
b50bff6
Compare
Commandeering this PR to me as I am picking up the issue #302 |
davidgxue
changed the title
Add banner for ask-astro down time
Add Backend Message and Frontend Banner for Service Maintenance
Feb 29, 2024
davidgxue
requested review from
Lee-W,
pankajastro,
davidgxue and
jlaneve
as code owners
February 29, 2024 17:15
Lee-W
reviewed
Mar 1, 2024
pankajastro
approved these changes
Mar 1, 2024
sunank200
commented
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But requesting to add the test cases for the changes in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
health_status
endpoint on backend that reads from the env varmaintenance
or if backend has no response coming backTests
SERVICE_MAINTENANCE_BANNER=True
closes #302