Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify paho version & fix typo #1146

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

GavinZhengOI
Copy link
Contributor

Description

  • clarify paho-mqtt version in this document
  • added missing double quote

Related issue(s)

See also #1145

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

derberg
derberg previously approved these changes Mar 25, 2024
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🚀

@Florence-Njeri please have a look and approve

@Florence-Njeri
Copy link
Collaborator

@derberg on it

Florence-Njeri
Florence-Njeri previously approved these changes Mar 25, 2024
@Florence-Njeri Florence-Njeri dismissed stale reviews from derberg and themself via 5f294d1 March 25, 2024 13:19
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@derberg
Copy link
Member

derberg commented Mar 27, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 0b7dd90 into asyncapi:master Mar 27, 2024
14 checks passed
@derberg
Copy link
Member

derberg commented Mar 27, 2024

@allcontributors please add @GavinZhengOI for docs

Copy link
Contributor

@derberg

I've put up a pull request to add @GavinZhengOI! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.17.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants