feat: enable noOverwriteGlobs for templates based on react engine
#1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmgyuan
requested review from
derberg,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
lmgyuan
changed the title
lmgyuan
changed the title
lmgyuan
changed the title
derberg
changed the title
noOverwriteGlobs for templates based on react engine
derberg
reviewed
Jul 15, 2024
There was a problem hiding this comment.
@lmgyuan please have a look on the PR title, how I changed it - it is always very important to have good meaningful titles as we use them as commit messages and they help a lot long term, with maintenance, when digging into history - bug hunting 😄
also please remove .idea from that PR - add it to .gitignore later
although I think you didn't update the PR after our last meeting
|
|
@lmgyuan you need to solve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add noOverwriteGlobs parameters to methods saveContentToFile and saveRenderedReactContent
pass this.noOverwriteGlobs to saveContentToFile
check the name of file to be written against the noOverwriteGlobs to determine whether it should be actually written to the target directory
add additional comments to relevant codes in the codebase so they are easier for future maintainers and contributors to understand.
Related issue(s)
Fixes #1128