This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fix @atom/notify subprocess path resolution when V8 startup snapshot is in effect #19331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't rely on `__dirname` inside a snapshotted file. Now path resolution takes place inside a specific file that is excluded from the startup snapshot.
|
Can confirm this fixes the issue 👍 |
|
Another spurious fuzzy finder failure, which is being tracked in atom/fuzzy-finder#386. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19311 (for real this time)
In #19325, I excluded
@atom/notify's subprocess binary from the ASAR bundle, but didn't realize there was another problem prohibiting spawning, which was the fact that__dirnameis invalid inside of the V8 startup snapshot.In this PR, we move resolution of the subprocess binary path to a separate file and exclude it from the snapshot to prevent this issue.
🍐'd with @as-cii