Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${foo.__} should not expand to parent node #1126

Merged
merged 1 commit into from
Jan 21, 2019
Merged

${foo.__} should not expand to parent node #1126

merged 1 commit into from
Jan 21, 2019

Conversation

siteshwar
Copy link
Contributor

This was an experimental feature that was added after last stable
release. Disable it.

Related: #1116

@krader1961
Copy link
Contributor

LGTM modulo also removing the now unused nv_parentnode() implementation.

This was an experimental feature that was added after last stable
release. Disable it.

Related: #1116
@siteshwar siteshwar merged commit 8886cd7 into att:master Jan 21, 2019
@dannyweldon
Copy link

While this was initially experimental, it was subsequently documented in the man page after some bugs were fixed and regression tests were added, which would indicate that it was considered ready for release.

13-08-23  Documented __ in sh.1 man page.
13-08-22 Fixed __ to work in nested types.

So if you still want it disabled, you might want to remove the man page entry and the regression tests. It is an important but minor feature btw for user-defined types and it would be a shame to delay it's release, but whatever.

@siteshwar
Copy link
Contributor Author

So if you still want it disabled, you might want to remove the man page entry and the regression tests.

You are right. I was still going through this code before removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants