Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in release files #352

Closed
wants to merge 3 commits into from
Closed

Fix typos in release files #352

wants to merge 3 commits into from

Conversation

catull
Copy link
Contributor

@catull catull commented Jan 12, 2018

Again, apologies for the trimming of white-space at the end of lines.
My editor does this automatically.

krader1961
krader1961 reviewed Jan 12, 2018
View reviewed changes
src/cmd/ksh93/RELEASE93
@@ -61,11 +61,11 @@ of ksh.
performed arithmetic evaluation when the discipline
was called from the arithmetic evaluator has been fixed.
e. A bug caused by an EXIT trap inside a function that
was executed in a subshell was fixed.
was executed in a sub-shell was fixed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, subshell is the more common spelling. And in as much as both are acceptable variants this is a gratuitous change.

krader1961
krader1961 reviewed Jan 12, 2018
View reviewed changes
src/cmd/ksh93/RELEASE93
@@ -234,20 +234,20 @@ of ksh.
%b in the format string are no longer displayed when
the operand contains \c.
e. A bug in printf that could cause the %E format to
produce unnormalized results has been fixed.
produce un-normalized results has been fixed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: unnormalized is the preferred, and more common, form.

krader1961
krader1961 reviewed Jan 12, 2018
View reviewed changes
src/cmd/ksh93/RELEASE93
fixed.
c. Code to for IFS handling of multibyte characters has
c. Code to for IFS handling of multi-byte characters has
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, again, the hyphenated form is far less commonly seen.

krader1961
krader1961 reviewed Jan 12, 2018
View reviewed changes
src/cmd/ksh93/RELEASE93 Outdated
typeset, and execution traces has been fixed.
e. A bug with type ahead and KEYBOARD traps with the
MULTIBYTE option set has been fixed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uppercase form is referring to an option and should remain as is.

@krader1961
Copy link
Contributor

Merged with the changes I commented on.

@krader1961 krader1961 closed this Jan 12, 2018
@catull catull deleted the fix-typos-in-RELEASE-files branch January 13, 2018 00:33
JohnoKing added a commit to JohnoKing/ksh that referenced this pull request Aug 6, 2020
@JohnoKing
Fix a large number of typos and other problems
4b0c9fc 
Most of these fixes are for typos and extra whitespace at the
end of lines. These are the notable changes:
- Fixed a compatibility issue with how asterisks are displayed
  using certain fonts. Bug report: att#764
- Fixed a bug in the man page that caused searches for the '|'
  character to fail. Bug report: att#871
- Removed a duplicate description of 'set -B' from the man
  page. Bug report: att#789
- Added documentation for options missing from the ksh man
  page (applies to 'hist -N', 'sleep -s', 'whence -q' and
  many of ulimit's options). Bug reports:
  att#948
  att#503 (comment)
  att#507 (comment)
- Applied the following ksh2020 man page fixes:
  att#351
  att#352
- Fixed a minor GCC -Wformat warning in procopen.c by changing
  NiL to NULL.
JohnoKing added a commit to JohnoKing/ksh that referenced this pull request Aug 6, 2020
@JohnoKing
Fix a large number of typos and other problems
3169491 
Most of these fixes are for typos and extra whitespace at the
end of lines. These are the notable changes:
- Fixed a compatibility issue with how asterisks are displayed
  using certain fonts. Bug report: att#764
- Fixed a bug in the man page that caused searches for the '|'
  character to fail. Bug report: att#871
- Removed a duplicate description of 'set -B' from the man
  page. Bug report: att#789
- Added documentation for options missing from the ksh man
  page (applies to 'hist -N', 'sleep -s', 'whence -q' and
  many of ulimit's options). Bug reports:
  att#948
  att#503 (comment)
  att#507 (comment)
- Applied the following ksh2020 man page fixes:
  att#351
  att#352
- Fixed a minor GCC -Wformat warning in procopen.c by changing
  a sentinel NULL.
JohnoKing added a commit to JohnoKing/ksh that referenced this pull request Aug 6, 2020
@JohnoKing
Fix a large number of typos and other problems
635e2dc 
Most of these fixes are for typos and extra whitespace at the
end of lines. These are the notable changes:
- Fixed a compatibility issue with how asterisks are displayed
  using certain fonts. Bug report: att#764
- Fixed a bug in the man page that caused searches for the '|'
  character to fail. Bug report: att#871
- Removed a duplicate description of 'set -B' from the man
  page. Bug report: att#789
- Added documentation for options missing from the ksh man
  page (applies to 'hist -N', 'sleep -s', 'whence -q' and
  many of ulimit's options). Bug reports:
  att#948
  att#503 (comment)
  att#507 (comment)
- Applied the following ksh2020 man page fixes:
  att#351
  att#352
- Fixed a minor GCC -Wformat warning in procopen.c by changing
  a sentinel NULL.
JohnoKing added a commit to JohnoKing/ksh that referenced this pull request Aug 6, 2020
@JohnoKing
Fix a large number of typos and other problems
b274fd1 
Most of these fixes are for typos and extra whitespace at the
end of lines. These are the notable changes:
- Fixed a compatibility issue with how asterisks are displayed
  using certain fonts. Bug report: att#764
- Fixed a bug in the man page that caused searches for the '|'
  character to fail. Bug report: att#871
- Removed a duplicate description of 'set -B' from the man
  page. Bug report: att#789
- Added documentation for options missing from the ksh man
  page (applies to 'hist -N', 'sleep -s', 'whence -q' and
  many of ulimit's options). Bug reports:
  att#948
  att#503 (comment)
  att#507 (comment)
- Applied the following ksh2020 man page fixes:
  att#351
  att#352
- Fixed a minor GCC -Wformat warning in procopen.c by changing
  a sentinel NULL.
JohnoKing added a commit to JohnoKing/ksh that referenced this pull request Aug 6, 2020
@JohnoKing
Fix a large number of typos and other problems
3fb87eb 
Most of these fixes are for typos and extra whitespace at the
end of lines. These are the notable changes:
- Fixed a compatibility issue with how asterisks are displayed
  using certain fonts. Bug report: att#764
- Fixed a bug in the man page that caused searches for the '|'
  character to fail. Bug report: att#871
- Removed a duplicate description of 'set -B' from the man
  page. Bug report: att#789
- Added documentation for options missing from the ksh man
  page (applies to 'hist -N', 'sleep -s', 'whence -q' and
  many of ulimit's options). Bug reports:
  att#948
  att#503 (comment)
  att#507 (comment)
- Applied the following ksh2020 documentation fixes:
  att#351
  att#352
- Fixed a minor GCC -Wformat warning in procopen.c by changing
  a sentinel NULL.
@JohnoKing JohnoKing mentioned this pull request Aug 6, 2020
Merged
JohnoKing added a commit to JohnoKing/ksh that referenced this pull request Aug 6, 2020
@JohnoKing
Fix a large number of typos and other problems
1d37577 
Most of these fixes are for typos and extra whitespace at the
end of lines. These are the notable changes:
- Fixed a compatibility issue with how asterisks are displayed
  using certain fonts. Bug report: att#764
- Fixed a bug in the man page that caused searches for the '|'
  character to fail. Bug report: att#871
- Removed a duplicate description of 'set -B' from the man
  page. Bug report: att#789
- Added documentation for options missing from the ksh man
  page (applies to 'hist -N', 'sleep -s', 'whence -q' and
  many of ulimit's options). Bug reports:
  att#948
  att#503 (comment)
  att#507 (comment)
- Applied the following ksh2020 documentation fixes:
  att#351
  att#352
- Fixed a minor GCC -Wformat warning in procopen.c by changing
  a sentinel to NULL.
McDutchie pushed a commit to ksh93/ksh that referenced this pull request Aug 6, 2020
@JohnoKing
Fix a large number of typos and other problems (#110)
f9fdbfc 
Most of these fixes are for typos and extra whitespace at the
end of lines. These are the notable changes:
- Fixed a compatibility issue with how asterisks are displayed
  using certain fonts. Bug report: att#764
- Fixed a bug in the man page that caused searches for the '|'
  character to fail. Bug report: att#871
- Removed a duplicate description of 'set -B' from the man
  page. Bug report: att#789
- Added documentation for options missing from the ksh man
  page (applies to 'hist -N', 'sleep -s', 'whence -q' and
  many of ulimit's options). Bug reports:
  att#948
  att#503 (comment)
  att#507 (comment)
- Applied the following ksh2020 documentation fixes:
  att#351
  att#352
- Fixed a minor GCC -Wformat warning in procopen.c by changing
  a sentinel to NULL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krader1961 krader1961 krader1961 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catull @krader1961