fix or skip some tests in OpenBSD #495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for att#483
The value of ${.sh.sig.code} is SI_QUEUE if the system supports
sigqueue(), or SI_USER otherwise.
Partial fix for att#483
OpenBSD accepts "x" as an alias of "C", and I can't use `locale -a` to detect this. If $(uname) is OpenBSD, then use "x.x" as the unknown locale. Most other systems agree that "x" is unknown. If `locale -a` shows that someone added the "x" locale, then skip the test. Partial fix for att#483
|
LGTM. Much thanks, @kernigh. I'll merge later tonight when I'm home. |
JohnoKing
added a commit
to JohnoKing/ksh
that referenced
this pull request
Mar 30, 2021
src/cmd/ksh93/tests/variables.sh - On OpenBSD 'x' functions as an alias for the 'C' locale, which causes regression tests that assume 'x' is an invalid locale to fail. Additionally, the regression tests didn't account for if 'x' is manually added by the user as a valid locale. The fix for both of these issues was backported from ksh2020: att#495. To avoid regression test failures on OpenBSD, an invalid 'x.x' locale is now used. To fix the other problem, 'locale -a' is used to look for an 'x' locale that would cause the regression tests to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reported in #483 that some tests fail in OpenBSD, because of differences between OpenBSD and other systems. These commits edit the tests sh_match.sh, signal.sh, and variables.sh to give "OK" on OpenBSD.
The remaining tests that "FAIL" are these: