Fix pathdev() handling of symlinks #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the io.sh unit test on any platform which has two consecutive symlinks in the temp directory pathname that points to a path longer than the symlink. It also introduces a regression test which fails on Linux (where /tmp isn't normally a symlink) without this change. Note that I do not claim this change is 100% correct. The original code is borderline impossible to understand. But this does fix the problem and doesn't introduce any new unit test failures. Partial fix for #483 Resolves #492
|
@krader1961 Thanks for taking time to fix this. But I think it would be better to remove |
I agree. I'm going to merge this anyway since we need to allow at least a couple of weeks to discuss that proposal. In the meantime this reduces test failures on macOS from 11 to 9 and fixes a bug that is visible on every OS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the io.sh unit test on any platform which has two consecutive
symlinks in the temp directory pathname that points to a path longer than
the symlink. It also introduces a regression test which fails on Linux
(where /tmp isn't normally a symlink) without this change.
Note that I do not claim this change is 100% correct. The original code
is borderline impossible to understand. But this does fix the problem
and doesn't introduce any new unit test failures.
Partial fix for #483
Resolves #492