sched_yield rather than sleep #548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several unit tests utilize very short duration sleeps (e.g., 100 usec) while waiting for something to happen. The problem with this is that on some platforms the minimum sleep interval might be 1, 10, even 100 msec. Which means the test can take one or two orders of magnitude longer to run on those platforms compared to a platform where sleeps are more granular. So instead of sleeping simply yield execution to another runable thread. This reduces the unit test run time for me from 49 minutes to 20 minutes on OpenBSD in a virtual machine. And from 35 minutes to 16 minutes on Cygwin. Partial fix for #483 Partial fix for #546
|
Merged since it is obviously better on some platforms and doesn't introduce any issues on the platforms that were already running the affected tests quickly. The Travis failures are the usual flakey failures having nothing to do with the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several unit tests utilize very short duration sleeps (e.g., 100 usec)
while waiting for something to happen. The problem with this is that
on some platforms the minimum sleep interval might be 1, 10, even
100 msec. Which means the test can take one or two orders of magnitude
longer to run on those platforms compared to a platform where sleeps are
more granular. So instead of sleeping simply yield execution to another
runable thread.
This reduces the unit test run time for me from 49 minutes to 20 minutes
on OpenBSD in a virtual machine. And from 35 minutes to 16 minutes on
Cygwin.
Partial fix for #483
Partial fix for #546