V3 #204
Merged
V3 #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tests were failing because the IV used to derive the encryption key was changing everytime the Proc was evaluated. - Other tests were failing because the default mode was :per_attribute_iv and the IV wasn't persisted because the column was missing.
- Decrypting the attribute_was value requires some special handling now that we're changing the IV during every encryption operation. Namely, we have to evaluate all the options for the attribute and pass in the encrypted_attribute_iv_was and the encrypted_attribute_salt_was to properly decrypt the encrypted_attribute_was value. - We delete the :iv, :salt, and :operation keys from the encrypted_attributes hash that were used to decrypt the encrypted_attribute_was value just to be safe. Normally those values are not persisted in the encrypted_attributes hash.
- This is required for passing in the IV and salt to decrypted the encrypted_attribute_was ciphertext. - The options evaluated should be used from the instance level, not the class level.
|
This closes #203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bump to v3: