Get repo to run #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added info about which directory each python file is stored in. * Added info about possibly having to use `sudo` in order to install python packages on MacOSX. * Changed python package from PIL to pillow because PIL no longer exists as a package in pip.
If there is no folder in ./data/images, when you run `python download_muct.py`, it will actually try to create a blob of data called 'images' rather than having a directory. So having READMEs avoids this problem.
This will now stop downloading files from `download_more.py` that don't return a 200 response and won't try to parse bad files as an additional check.
|
If you want to see clearer changes that ignore whitespace, https://github.com/auduno/clmtools/pull/3/files?w=1 |
|
Many thanks for the fixes! I haven't run the code from scratch, so I wasn't aware of the issue with the missing images and negatives folders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've been making some changes to get this repo to work. I've added some documentation to the README that I was initially confused about, and also made some points about running this on MacOSX.
The main things I added were:
imagesandnegativesfolder with README files. Without these directories being initially created, runningdownload_muct.pyends up piping its output to a file calledimagesinstead of a directory.download_more.pyno longer exists or sometimes generate non-image files. I've added a lot of extra checks so they don't get parsed as normal images. I didn't actually remove the files, just ignore them since I'm not sure whether the better option is to just remove all the invalid files.