Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'RefreshState' public #1158

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

davesmits
Copy link
Contributor

Should fix #1157

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (2abba7e) 77.79% compared to head (2c6a4ed) 77.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
+ Coverage   77.79%   77.80%   +0.01%     
==========================================
  Files          45       45              
  Lines        1725     1726       +1     
  Branches      343      346       +3     
==========================================
+ Hits         1342     1343       +1     
- Misses        342      343       +1     
+ Partials       41       40       -1     
Flag Coverage Δ
unittests 77.80% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/RefreshState.ts 100.00% <ø> (ø)
src/index.ts 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa
Copy link
Member

pamapa commented Sep 4, 2023

change is good, what surprises me is that docs\oidc-client-ts.api.md has not changed... ?

@davesmits
Copy link
Contributor Author

Can you guido me how to get it updated? npm run build doesnt seem to do the trick

@pamapa
Copy link
Member

pamapa commented Sep 5, 2023

Can you guido me how to get it updated? npm run build doesnt seem to do the trick

I guess you will need to add this type to the index.ts..

@davesmits
Copy link
Contributor Author

@pamapa think this is better

@pamapa pamapa added this to the 2.3.0 milestone Sep 5, 2023
@pamapa pamapa merged commit 866a75a into authts:main Sep 5, 2023
2 checks passed
@pamapa
Copy link
Member

pamapa commented Sep 5, 2023

thanks for contributing

dbfr3qs pushed a commit to dbfr3qs/oidc-client-ts that referenced this pull request Apr 3, 2024
* make 'RefreshState' public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC Client; can refresh token externally as RefreshState is not exportered
2 participants