Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnitTests] Popup window not close after some time #1165

Conversation

kwojtasinski-repo
Copy link
Contributor

@kwojtasinski-repo kwojtasinski-repo commented Sep 11, 2023

Closes/fixes #issue

Added unit tests to provide better code coverage

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (9f6ec0d) 77.80% compared to head (1c4a2e4) 77.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
+ Coverage   77.80%   77.92%   +0.11%     
==========================================
  Files          45       45              
  Lines        1726     1726              
  Branches      346      346              
==========================================
+ Hits         1343     1345       +2     
+ Misses        343      342       -1     
+ Partials       40       39       -1     
Flag Coverage Δ
unittests 77.92% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/navigators/PopupWindow.ts 90.62% <100.00%> (+6.25%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa pamapa added this to the 2.3.0 milestone Sep 12, 2023
@pamapa pamapa merged commit b342d2c into authts:main Sep 12, 2023
4 checks passed
@pamapa
Copy link
Member

pamapa commented Sep 12, 2023

nice, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants