Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMR: Host function block hash provider for pallet-mmr #2679

Closed
wants to merge 2 commits into from

Conversation

vedhavyas
Copy link
Contributor

This PR upgrades the subspace fork to introduce change from this upstream PR

Code contributor checklist:

NingLin-P

This comment was marked as duplicate.

@vedhavyas vedhavyas added this pull request to the merge queue Apr 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 15, 2024
@vedhavyas
Copy link
Contributor Author

I'll open a PR again with same changes rebased on main rather than resolvong this many conflicts

@vedhavyas vedhavyas closed this Apr 15, 2024
@nazar-pc
Copy link
Member

Conflicts are actually minimal due to some unrelated dependencies updates.

@vedhavyas
Copy link
Contributor Author

Conflicts are actually minimal due to some unrelated dependencies updates.

Rebasing would be much faster this case else I have to fix conflicts in each file. The PR should be up now

@vedhavyas vedhavyas deleted the pallet-mmr-upgrade branch April 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants