-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing initialization of self.info #1088
Conversation
e54fab8
to
f1451a1
Compare
@Maximellerbach - can you have a look at this? |
@DocGarbanzo the type of self.info['lidar'] should be a np.array, I'm not sure of the expected behavior when the array is empty ? Are we checking somewhere if the array of point is empty / matches the expected shape the model needs ? |
Currently the lidar data is not used in any models. For now it's just being recorded into the tub, as it would be returned in the |
Maybe I'm missing something, why should it be a python list ? I am currently returning from GymDonkeycar a numpy array, if you confirm it should be a list then I will also change it on this side |
I think the older drivers return an np.array() and the newer drivers return a python list. I would go with the newer drivers. This is what the new driver puts out: donkeycar/donkeycar/parts/lidar.py Line 171 in c4d9091
|
Ok ! I will then align with those. |
So I think we can merge this @DocGarbanzo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sisaha9
Fixes #1086