- fix web controller recording state so it is latched. #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ezward
commented
Apr 5, 2022
Ezward
commented
- fix for JPG files don't recording in the data folder #996
- version="4.3.10"
- fix for #996 - version="4.3.10"
DocGarbanzo
approved these changes
Apr 6, 2022
| self.application.angle = data.get('angle', self.application.angle) | ||
| self.application.throttle = data.get('throttle', self.application.throttle) | ||
| if data.get('drive_mode') is not None: | ||
| self.application.mode = data['drive_mode'] | ||
| self.application.mode_latch = self.application.mode | ||
| self.application.recording = data.get('recording', self.application.recording) | ||
| if data.get('recording') is not None: |
There was a problem hiding this comment.
Just a comment for future improvements. Because you are already getting the entry from the dict, you could use it in the next line, w/o getting it again, i.e.
recording = data.get('recording')
if recording is not None:
self.application.recording = recording
self.application.recording_latch = self.application.recordingor even
recording = data.get('recording')
if recording is not None:
self.application.recording_latch = self.application.recording = recording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.