Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete kurtosis e2e job #345

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Delete kurtosis e2e job #345

merged 2 commits into from
Sep 27, 2023

Conversation

marun
Copy link
Contributor

@marun marun commented Sep 22, 2023

Why this should be merged

Kurtosis has been deprecated in favor of avalanchego e2e testing as per ava-labs/avalanchego#1547.

How this works

  • Removes kurtosis e2e job and associated script

TODO

@marun marun linked an issue Sep 22, 2023 that may be closed by this pull request
16 tasks
@marun marun force-pushed the delete-kurtosis branch 2 times, most recently from 5f73cb2 to 44ca4b5 Compare September 25, 2023 08:28
# mv avalanchego/ to nested dir avalanchego/avalanchego/
# required because docker instruction "COPY dir ." copies dir/* to .
run: mkdir avalanchego_tmp && mv avalanchego avalanchego_tmp && mv avalanchego_tmp avalanchego
- run: .github/workflows/run_e2e_tests.sh --parallelism 1 --client-id $KURTOSIS_CLIENT_ID --client-secret $KURTOSIS_CLIENT_SECRET
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we remove run_e2e_tests.sh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, good call. Done.

Copy link
Collaborator

@darioush darioush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@darioush darioush merged commit 9e81afe into master Sep 27, 2023
7 of 8 checks passed
@darioush darioush deleted the delete-kurtosis branch September 27, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate Kurtosis Tests
3 participants