Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no internal linter for examples #1594

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RodrigoVillar
Copy link
Collaborator

This PR revolves #1572 by adding a simple linter at checks for the use of internal packages within examples/

If the linter passes, it returns the following:

Ok.

If there is an instance of internal being used, it returns a similar message as seen below for each violation and exits with code 1:

Violation: /Users/rodrigo.villar/go/src/github.com/ava-labs/hypersdk/examples/morpheusvm/actions/transfer.go imports from /internal

This PR also adds the internal linter as part of the CI tests for HyperSDK

@aaronbuchwald
Copy link
Collaborator

Would it be possible to look into why depguard is not giving us what we want here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants