[x/programs] add program abstraction #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
samliok
reviewed
Dec 22, 2023
x/programs/program/utils.go
Outdated
| import "math" | ||
|
|
||
| // EnsureInt64ToInt32 returns true if a [v] (int64) can be safely converted to an int32. | ||
| func EnsureInt64ToInt32(v int64) bool { |
There was a problem hiding this comment.
we can remove this func since we don't use it
samliok
requested changes
Jan 5, 2024
hexfusion
requested review from
dboehm-avalabs and
richardpringle
as code owners
samliok
previously approved these changes
Jan 6, 2024
samliok
reviewed
Jan 6, 2024
samliok
reviewed
Jan 6, 2024
This reverts commit 15b84b5.
samliok
reviewed
Jan 6, 2024
| return nil, err | ||
| } | ||
|
|
||
| exp, err = i.GetExport(program.AllocFnName) |
There was a problem hiding this comment.
we require the instance to export an alloc function here, might make sense to make this optional
samliok
approved these changes
Jan 6, 2024
patrick-ogrady
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #657 and #658