Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animation spinner fills the console with new lines #2541

Closed
dcsan opened this issue Jul 14, 2020 · 6 comments · Fixed by #2556
Closed

animation spinner fills the console with new lines #2541

dcsan opened this issue Jul 14, 2020 · 6 comments · Fixed by #2556
Assignees
Labels
bug current functionality does not work as desired help wanted scope:reporters

Comments

@dcsan
Copy link

dcsan commented Jul 14, 2020

The little animation spinner is cute as the tests are running, however it seems to degrade and then put a newline on every iteration. My test run ends up filling pages of console

image

if the feature is broken, is there a way to at least disable it?

⠙ Actor › game loading
⠹ Actor › game loading
⠸ Actor › game loading
⠼ Actor › game loading
⠴ Actor › game loading
⠦ Actor › game loading
@novemberborn
Copy link
Member

Yea that's not good.

It should be better with --verbose or verbose: true in the configuration.

@novemberborn novemberborn added bug current functionality does not work as desired help wanted scope:reporters and removed needs triage labels Jul 15, 2020
@novemberborn
Copy link
Member

I assume you have some console.log() output in the test / tested code?

@dcsan
Copy link
Author

dcsan commented Jul 15, 2020

yes there are some logs there
reply input: xx

so perhaps that triggered the new lines to be happening...

image

@G-Rath
Copy link

G-Rath commented Jul 29, 2020

I hit then when using ava for the first time when implementing a feature in np:

image

The above is a slice of a very long output filled with more of the same 😬

While the loading spinner is indeed very pretty, having the ability to disable would be a great short-term solution.

@novemberborn novemberborn self-assigned this Aug 1, 2020
@novemberborn
Copy link
Member

Aha! While we try to clear the spinner (on stdout), before writing the output from the test (to stderr)… we don't wait for this to complete. I think I know how to fix this…

novemberborn added a commit that referenced this issue Aug 1, 2020
The spinner is not cleared while the stream is corked, which then
corrupts the printing of stdout / stderr chunks received from the test
processes.

Fixes #2541
novemberborn added a commit that referenced this issue Aug 1, 2020
The spinner is not cleared while the stream is corked, which then
corrupts the printing of stdout / stderr chunks received from the test
processes.

Fixes #2541
@novemberborn
Copy link
Member

This should be fixed in master now. Normally I do releases at the end of the weekend, so it should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug current functionality does not work as desired help wanted scope:reporters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants