Fix broken CLI on Windows #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ var debug = require('debug')('ava'); | |||
| var resolveCwd = require('resolve-cwd'); | |||
| var localCLI = resolveCwd('ava/cli'); | |||
|
|
|||
| if (localCLI && localCLI !== __filename) { | |||
| if (localCLI && path.relative(localCLI, __filename) !== '') { | |||
There was a problem hiding this comment.
Can you add a comment referencing nodejs/node#6624 for posterity. Otherwise someone will come by and try to simplify the code without understanding what it's solving.
vadimdemedes
force-pushed
the
fix-windows-cli
branch
from
a1cdf14
to
3253860
Compare
|
PR updated. |
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #984.
Thanks to @eugirdor for reporting the issue and for the fix.