Add fixer for the no-only-test rule

[florianb]

No description provided.

[sindresorhus]

Can you also mark it fixable in the docs, like done here https://github.com/sindresorhus/eslint-plugin-unicorn#rules

[sindresorhus]

I would do:

const range = getTestModifier(node, 'only').range.slice();
range[0] -= 1;
return fixer.removeRange(range);

[florianb]

✔️

[sindresorhus]

Use arrow-function.

[sindresorhus]

And move it to util.js

[florianb]

✔️

[sindresorhus]

This is not needed.

[florianb]

✔️

[florianb]

Okay @sindresorhus - i finally made the changes, apologies for the delay.

Moving getTestModifier to util made it necessary using a named function instead of an arrow function. Let me know if further changes are needed. 🍸

[jfmengels]

Hi @florianb, thanks for your work on this :)

I would like to add three cases to the tests. The third one fails and currently creates incorrect JS code (test.(t => { t.pass(); });).

		{
			code: header + 'test\n  .only(t => { t.pass(); });',
			output: header + 'test\n  (t => { t.pass(); });',
			errors
		},
		{
			code: header + 'test  .only(t => { t.pass(); });',
			output: header + 'test  (t => { t.pass(); });',
			errors
		},
		{
			code: header + 'test.\n  only(t => { t.pass(); });',
			output: header + 'test\n  (t => { t.pass(); });',
			errors
		}

That said, I'm actually against having this rule be fixable 🤔
I use autofix a lot now (manually), for things like formatting (especially since I started using prettier and a lot of core rules became autofixable), and some people even have it run automatically on save. Having this rule be fixable means that you can not run the autofix (or even save your file?) while you want to run some tests with only.

[florianb]

Hi @jfmengels - thanks for suggesting the test-cases, they are perfectly valid!

I absolutely understand your opinion, to be honest, i picked that rule since i wanted to help out and the no-only-rule wasn't discussed controversial in #21. I will wait with any further activities until the members found a consent on this.

But to add something to the discussion - i use fixes to make my current work compliant before pushing to the remote.

[sindresorhus]

Having this rule be fixable means that you can not run the autofix (or even save your file?) while you want to run some tests with only.

That can be solved in the editor plugins though, like AtomLinter/linter-eslint#795.

[jfmengels]

Ah, I didn't know about that, that's great to hear.
I think most people will not use that, but it's probably worth trying adding it. If it bothers a lot of people, we can always explain in the docs how to disable the autofixing in the editor.
👍 for me then, pending the addition of the tests that I put above.

[sindresorhus]

And in atom-linter-xo, I can disable the auto-fix for it when fixing on save.

[florianb]

Aye - thanks, going to add the test. ⏳

[florianb]

@jfmengels - i added additional tests using tabs instead of spaces.
@sindresorhus - done, even though i guess you'll have to refine my style for your final pleasure. 😄

[jfmengels]

LGTM. Thanks @florianb :)