Add fixer for no-skip-test rule
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 27, 2017 14:17
Includes refactorings to reuse code introduced with making `ino-only-test` fixable.
This is necessary to enable node 4 compliance.
|
Ready to 🚢 |
|
Don't commit Line 1 in 8e5d631 |
sindresorhus
reviewed
Dec 2, 2017
util.js
Outdated
| while (source.charAt(dotPosition) !== '.') { | ||
| dotPosition -= 1; | ||
| } | ||
| let snippet = source.substring(dotPosition, range[1]); |
There was a problem hiding this comment.
Can you use slice instead of substring? I know it was like this already, but better for consistency. I always use slice over substring.
There was a problem hiding this comment.
Of course - i am happily copying (most of) your habits.. 😸
|
I really have no clue, how the package-lock was generated - i'm not using more commands than |
|
Aehm - |
|
Thank you @florianb :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces fixes for the
no-skip-test-rule as requested in #21.This work is based on the implementation of the fix for the
no-only-test-rule.