Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove options from the test-title rule #224

Merged
merged 4 commits into from
May 17, 2019
Merged

Remove options from the test-title rule #224

merged 4 commits into from
May 17, 2019

Conversation

GMartigny
Copy link
Contributor

fix #185

@GMartigny
Copy link
Contributor Author

Hi,
First draft to be sure I'm going the right way. Tests have been updated, but not docs yet.
As per #185 (comment), the rule only errors when there's no argument or the first one is a function.

@sindresorhus sindresorhus changed the title test-title only errored when first argument is a function Remove options from the test-title rule Apr 30, 2019
@sindresorhus
Copy link
Member

The implementation direction looks good to me.

@sindresorhus
Copy link
Member

Is this ready?

@GMartigny
Copy link
Contributor Author

Is this ready?

It is for me.

@sindresorhus sindresorhus merged commit 1218892 into avajs:master May 17, 2019
@GMartigny GMartigny deleted the testTitle branch May 21, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove options from the test-title rule
2 participants
@GMartigny @sindresorhus