Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-inline-assertions rule #262

Merged
merged 19 commits into from
Jul 5, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/rules/no-inline-assertions.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
# Ensure assertions are not called from inline arrow functions

An inline arrow function is an arrow function with concise body, i.e. `x => x` will return `x` to the caller. The test implementation, composed of a series of assertions, should not be an inline arrow function as assertions do not return.
The test implementation should not purely consist of an inline assertion as assertions do not return a value and having them inline also makes the tests less readable.
sindresorhus marked this conversation as resolved.
Show resolved Hide resolved


## Fail

```js
import test from 'ava';

test('foo', t => t.true(fn()));
```


## Pass

```js
import test from 'ava';

Expand Down