Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go-test-coverage service link to PR template #5093

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vladopajic
Copy link
Contributor

@vladopajic vladopajic commented Nov 5, 2023

this PR adds link to go-test-coverage in pull request template.

reasoning to include go-test-coverage are following:

  • it provides the same level of functionality needed by repository owners (automated coverage check with badge display)
  • it's free and open source
  • it's easier to setup (no registration or permissions required)

Copy link

github-actions bot commented Nov 5, 2023

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • godoc.org or pkg.go.dev
  • goreportcard.com
  • coverage

your project is about to be approved, it's under revision, it may take a few days

@vladopajic
Copy link
Contributor Author

hello @avelino, could you review this PR? thanks!

@vladopajic
Copy link
Contributor Author

hello @phanirithvij, could you review this PR?

@phanirithvij
Copy link
Collaborator

I am not sure about this. Many repositories don't use GitHub or GitHub actions and thus suggesting it to everyone isn't ideal.
What do you think @avelino

@vladopajic
Copy link
Contributor Author

it's just additional option and developer can choose any method they would prefer.

@vladopajic
Copy link
Contributor Author

@phanirithvij @avelino

here is some statistics: on randomly selected repositories (n=100) from awesome-go list

  • 100 (all) repositories are using github
  • 36 repositories don't use github workflow
    • 10 repositories don't have continuous integration at all

based on this statistics it looks like there are more repositories (~64%) that would already easily integrate with this tool (since those already use github workflow).
from another view, 100% of those repositories are hosted on github, using github workflow is as easy as adding file in repository root.

since users can choose any method they like, there isn't any problem is suggesting any method.

personally, it's much more uncomfortable to use SaaS solutions that are already listed.

@xhd2015
Copy link
Contributor

xhd2015 commented Mar 30, 2024

not LGTM, we should not suggest using any specific tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants