-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add go-test-coverage service link to PR template #5093
base: main
Are you sure you want to change the base?
add go-test-coverage service link to PR template #5093
Conversation
Thank you for contributing with awesome-go, we will revise your contribution as soon as possible. Make sure you add the links in the body of the pull request that are requested in the contribution guide:
|
hello @avelino, could you review this PR? thanks! |
hello @phanirithvij, could you review this PR? |
I am not sure about this. Many repositories don't use GitHub or GitHub actions and thus suggesting it to everyone isn't ideal. |
it's just additional option and developer can choose any method they would prefer. |
here is some statistics: on randomly selected repositories (n=100) from awesome-go list
based on this statistics it looks like there are more repositories (~64%) that would already easily integrate with this tool (since those already use github workflow). since users can choose any method they like, there isn't any problem is suggesting any method. personally, it's much more uncomfortable to use SaaS solutions that are already listed. |
not LGTM, we should not suggest using any specific tool |
this PR adds link to go-test-coverage in pull request template.
reasoning to include
go-test-coverage
are following: