Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gondola #5344

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Add gondola #5344

merged 3 commits into from
Jun 26, 2024

Conversation

bmf-san
Copy link
Contributor

@bmf-san bmf-san commented Jun 23, 2024

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.

Thanks for your PR, you're awesome! 馃槑

@bmf-san bmf-san changed the title [update] add gondola Add gondola Jun 23, 2024
Copy link

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • repo link
  • pkg.go.dev
  • goreportcard.com
  • coverage

Your project is under review. It may take a few days to be approved.

Repository owner deleted a comment from Nicoleash333 Jun 25, 2024
@phanirithvij
Copy link
Collaborator

Coverage is low, as per awesome-go requirements it should be >80%

@phanirithvij phanirithvij self-assigned this Jun 25, 2024
@bmf-san
Copy link
Contributor Author

bmf-san commented Jun 25, 2024

@phanirithvij
Oh, sorry.
I improved the coverage to over 80%.
see: https://app.codecov.io/gh/bmf-san/gondola

@phanirithvij
Copy link
Collaborator

phanirithvij commented Jun 25, 2024

Did you format the file? Please revert that part only add a package.

@@ -2278,7 +2278,7 @@ _Libraries and tools for binary serialization._
- [flipt](https://github.com/markphelps/flipt) - A self contained feature flag solution written in Go and Vue.js
- [go-feature-flag](https://github.com/thomaspoignant/go-feature-flag) - A simple, complete and lightweight self-hosted feature flag solution 100% Open Source.
- [go-proxy-cache](https://github.com/fabiocicerchia/go-proxy-cache) - Simple Reverse Proxy with Caching, written in Go, using Redis.
- [gondola](https://github.com/bmf-san/gondola) - A golang reverse proxy.
- [gondola](https://github.com/bmf-san/gondola) - A YAML based golang reverse proxy.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed a description.

@bmf-san
Copy link
Contributor Author

bmf-san commented Jun 26, 2024

@phanirithvij
I am sorry, I made a mistake.
I fixed it. 9be7211

@phanirithvij phanirithvij merged commit 953a8db into avelino:main Jun 26, 2024
4 checks passed
@bmf-san bmf-san deleted the add-gondola branch June 26, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants