[pull] master from FluxML:master #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
819: Fix UnionAll stackoverflow r=DhairyaLGandhi a=DhairyaLGandhi
MWE:
```Julia
c = RGB(0,1,1)
t = RGB(1,1,1)
gradient(colordiff, c, t)
ERROR: StackOverflowError:
Stacktrace:
[1] unwrap_unionall at ./essentials.jl:234 [inlined]
[2] _pullback(::Zygote.Context, ::typeof(Base.unwrap_unionall), ::Type{M}) at /Users/dhairyagandhi/Downloads/new_clones/Zygote.jl/src/compiler/interface2.jl:0
[3] nameof at ./reflection.jl:211 [inlined]
...聽(the last 2 lines are repeated 43620 more times)
[87244] _pullback(::Zygote.Context, ::typeof(nameof), ::Type{M}) at /Users/dhairyagandhi/Downloads/new_clones/Zygote.jl/src/
```
This pointed me to check why there was a stackoverflow, which really shouldn't happen. In some cases, it crashes Julia entirely.
Turns out `nameof` which `UnionAll` structs can cause this but rewriting the complete function like so differentiates as expected.
```Julia
function mynameof(x::UnionAll)
while isa(x, UnionAll)
x = x.body
end
x.name.name
end
```
Since `nameof` would not produce gradients anyway, I went ahead and gave it a consistent gradient and added the couple other annotations needed to get the Colors.jl examples functional again.
Co-authored-by: Dhairya Gandhi <dhairya@juliacopmuting.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 馃挅 Please sponsor : )