AV-75971 Added support to select ESXi host #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grastogi23
suggested changes
Jan 15, 2020
library/deploy_se.py
Outdated
| @@ -105,18 +105,33 @@ def get_first_cluster(si, dc): | |||
| return first_cluster | |||
|
|
|||
|
|
|||
| def get_ds(dc, name): | |||
| def get_ds(dc, name, type='datacenter'): | |||
There was a problem hiding this comment.
type is a bad choice of name. type is a keyword and we should not override it. Also, I don't see how you are using the type? you are passing it down in the function but not using it.
There was a problem hiding this comment.
Changed the name. We are using this variable to show an accurate error in case of failure(datastore not found on datacenter/host).
grastogi23
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.