Upgrade deps #8
Merged
Upgrade deps #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the commits. I need time to analyze and verify that adding to dependencies is the only solution. I have doubts about adding ~11Mb unnecessary runtime dependencies to the package |
|
I'm not 100% convinced either. It could be a bug in yarn. In fact, mkfifo was working as-is a few months ago in dat-shell but a few days ago I wasn't able to run |
|
Found the related yarn issue, still unsolved: yarnpkg/yarn#3728 Suggested workaround is to install node-gyp globally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added node-gyp to dependencies to fix installation through yarn instead of npm.