Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .babelrc to .npmignore #317

Merged
merged 5 commits into from
Apr 6, 2018
Merged

Add .babelrc to .npmignore #317

merged 5 commits into from
Apr 6, 2018

Conversation

maxdavidson
Copy link
Contributor

When using amazon-cognito-identity-js with React Native, it tries to transpile the code using the published .babelrc file. It will choke if babel-preset-es2015 is not installed. This is unfortunately how RN's bundler works by default. By npmignoring it, the problem should be resolved.

See facebook/react-native#4062

@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files          69       69           
  Lines        3217     3217           
  Branches      611      611           
=======================================
  Hits         2872     2872           
  Misses        328      328           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c5d475...cd06d5a. Read the comment docs.

Copy link
Contributor

@richardzcode richardzcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@richardzcode richardzcode merged commit 2a1428d into aws-amplify:master Apr 6, 2018
@simonbuchan
Copy link

As a follow up, I'm not sure what triggers this, but doing this seems to also fix the redbox error: Unhandled JS Exception: Unexpected token '{'. import call expects exactly one argument. (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:196509) though it requires --reset-cache to flush out the old, bad transpilation.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants