Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudFormation Resource Specification 20.3.0 #1781

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Update specs to 20.3.0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@PatMyron
Copy link
Contributor

PatMyron commented Nov 13, 2020

another instance of awslabs/goformation#300
AssertionError: False != True : Specified property type AWS::DataBrew::Recipe. not found for property Parameters
Resource Specification snippet:

    "AWS::DataBrew::Recipe.Action": {
      "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-databrew-recipe-action.html",
      "Properties": {
        "Operation": {
          "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-databrew-recipe-action.html#cfn-databrew-recipe-action-operation",
          "UpdateType": "Mutable",
          "Required": true,
          "PrimitiveType": "String"
        },
        "Parameters": {
          "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-databrew-recipe-action.html#cfn-databrew-recipe-action-parameters",
          "UpdateType": "Mutable",
          "Required": false
        }
      }
    },

https://schema.cloudformation.us-east-1.amazonaws.com/aws-databrew-recipe.json

@PatMyron PatMyron added the spec CloudFormation Specification Bug label Nov 13, 2020
Comment on lines 51 to +53
'US West (Verizon) - San Francisco Bay Area': 'us-west-2',
'US East (Verizon) - Miami': 'us-east-1',
'US East (Verizon) - Dallas': 'us-east-1',
Copy link
Contributor

@PatMyron PatMyron Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it'd be worth supporting patterns if this list keeps growing
https://aws.amazon.com/about-aws/whats-new/2020/11/announcing-new-aws-wavelength-zones-in-dallas-and-miami/

Suggested change
'US West (Verizon) - San Francisco Bay Area': 'us-west-2',
'US East (Verizon) - Miami': 'us-east-1',
'US East (Verizon) - Dallas': 'us-east-1',
'US West (Verizon) - .*': 'us-west-2',
'US East (Verizon) - .*': 'us-east-1',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was starting to debate that too. I wonder if we can just drop the verizon data? I don't think it adds anything either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +1 to +3
# Auto generated files for testing
test/fixtures/templates/bad/limit_numbers.yaml
test/fixtures/templates/bad/limit_size.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍 should've added this in #1747 but too accustomed to testing remotely with Travis

@PatMyron PatMyron changed the title Update specs to 20.3.0 CloudFormation Resource Specification 20.3.0 Nov 14, 2020
@kddejong kddejong merged commit 447d00f into aws-cloudformation:master Nov 16, 2020
@kddejong kddejong deleted the update/specs/20.3.0 branch November 16, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec CloudFormation Specification Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants