chore(pre-commit) - Update pre-commit docs and better support for cfnlintrc #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
force-pushed
the
fix/issue/987
branch
from
178e6e1
to
8789872
Compare
kddejong
changed the title
mmaeng
reviewed
Oct 26, 2022
|
LGTM! |
benbridts
reviewed
Oct 27, 2022
| description: 'cfn-lint is a tool for finding issues with CloudFormation templates' | ||
| entry: cfn-lint | ||
| language: python | ||
| pass_filenames: false |
There was a problem hiding this comment.
I like this a lot (the three options)
There is a downside to this last option though, it will always scan all templates, even if you only change one
There was a problem hiding this comment.
yea, agreed. Trying to give some options so people can pick whats right for them. Besides making .cfnlintrc file work better with pre-commit scanning all templates as cfn-lint specs and rules change could be useful (maybe)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #987
Description of changes:
pre-commithooks including the updating of documentationBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.