Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 - cleanup config and add more tests #3204

Merged
merged 2 commits into from
May 2, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented May 2, 2024

Issue #, if available:

Description of changes:

  • V1 - cleanup config and add more tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (ac4d66c) to head (a4f5f62).

Additional details and impacted files
@@            Coverage Diff             @@
##               v1    #3204      +/-   ##
==========================================
+ Coverage   91.49%   91.95%   +0.45%     
==========================================
  Files         300      300              
  Lines       10968    10947      -21     
  Branches     2393     2379      -14     
==========================================
+ Hits        10035    10066      +31     
+ Misses        554      524      -30     
+ Partials      379      357      -22     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit b96c825 into aws-cloudformation:v1 May 2, 2024
21 checks passed
@kddejong kddejong deleted the v1-cleanup/2024/05/02 branch May 2, 2024 20:31
kddejong added a commit that referenced this pull request May 3, 2024
* Add more testing to increase coverage
* Create fixes and more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant