Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.24.0, code-generator v0.24.2 #96

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Feb 9, 2023

Update to ACK runtime v0.24.0, code-generator v0.24.2



NOTE:
This PR increments the release version of service controller from v1.0.0 to v1.0.1

Once this PR is merged, release v1.0.1 will be automatically created for applicationautoscaling-controller

Please close this PR, if you do not want the new patch release for applicationautoscaling-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building applicationautoscaling-controller ====
Copying common custom resource definitions into applicationautoscaling
Building Kubernetes API objects for applicationautoscaling
Generating deepcopy code for applicationautoscaling
Generating custom resource definitions for applicationautoscaling
Building service controller for applicationautoscaling
Generating RBAC manifests for applicationautoscaling
Running gofmt against generated code for applicationautoscaling
Updating additional GitHub repository maintenance files
==== building applicationautoscaling-controller release artifacts ====
Building release artifacts for applicationautoscaling-v1.0.1
Generating common custom resource definitions
Generating custom resource definitions for applicationautoscaling
Generating RBAC manifests for applicationautoscaling

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
@ack-prow
Copy link

ack-prow bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Feb 10, 2023
@ack-prow ack-prow bot merged commit 5506452 into main Feb 10, 2023
@a-hilaly
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants