Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial controller (no resource managers) #1

Merged
merged 1 commit into from
May 16, 2023

Conversation

jaypipes
Copy link
Contributor

Generated with controller-bootstrap:

make SERVICE=cloudwatch SERVICE_MODEL_NAME=logs

Issue aws-controllers-k8s/community#1093

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Generated with controller-bootstrap:

```
make SERVICE=cloudwatch SERVICE_MODEL_NAME=logs
```

Issue aws-controllers-k8s/community#1093

Signed-off-by: Jay Pipes <jaypipes@gmail.com>
@ack-prow
Copy link

ack-prow bot commented May 16, 2023

Hi @jaypipes. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 16, 2023
@ack-prow
Copy link

ack-prow bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member

Ty sir @jaypipes !

@a-hilaly a-hilaly merged commit a14f44a into aws-controllers-k8s:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants