Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generation regression for ec2-controller #1593

Closed
a-hilaly opened this issue Dec 13, 2022 · 3 comments
Closed

Code generation regression for ec2-controller #1593

a-hilaly opened this issue Dec 13, 2022 · 3 comments
Labels
area/code-generation Issues or PRs as related to controllers or docs code generation kind/regression Categorizes issue or PR as related to a regression from a prior release. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. service/ec2 Indicates issues or PRs that are related to ec2-controller.

Comments

@a-hilaly
Copy link
Member

A recent patch caused a regression that resulted in the code generated for the ec2-controller to not compile correctly. This means that the ec2-controller may not be functioning properly, potentially causing problems for users who rely on it.
@a-hilaly a-hilaly added area/code-generation Issues or PRs as related to controllers or docs code generation service/ec2 Indicates issues or PRs that are related to ec2-controller. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Dec 13, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Mar 14, 2023

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2023
@a-hilaly
Copy link
Member Author

Patch was reverted - and now we have an explicit panic explaining why it cannot be regenerated
/close

@ack-prow ack-prow bot closed this as completed Mar 15, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 15, 2023

@a-hilaly: Closing this issue.

In response to this:

Patch was reverted - and now we have an explicit panic explaining why it cannot be regenerated
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/code-generation Issues or PRs as related to controllers or docs code generation kind/regression Categorizes issue or PR as related to a regression from a prior release. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. service/ec2 Indicates issues or PRs that are related to ec2-controller.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-hilaly @ack-bot